[fix]: remove unused func

Signed-off-by: Sam Yuan <[email protected]>

pkg/collector/metric_collector.go

@@ -18,7 +18,6 @@ package collector
 
 import (
 	"os"
-	"sync"
 	"syscall"
 	"time"
 
@@ -63,15 +62,15 @@ type Collector struct {
 
 func NewCollector(bpfExporter bpf.Exporter) *Collector {
 	bpfSupportedMetrics := bpfExporter.SupportedMetrics()
-	c := &Collector{
+	c := Collector{
 		NodeStats:           *stats.NewNodeStats(),
 		ContainerStats:      map[string]*stats.ContainerStats{},
 		ProcessStats:        map[uint64]*stats.ProcessStats{},
 		VMStats:             map[string]*stats.VMStats{},
 		bpfExporter:         bpfExporter,
 		bpfSupportedMetrics: bpfSupportedMetrics,
 	}
-	return c
+	return &c
 }
 
 func (c *Collector) Initialize() error {
@@ -139,22 +138,12 @@ func (c *Collector) UpdateProcessEnergyUtilizationMetrics() {
 }
 
 func (c *Collector) updateResourceUtilizationMetrics() {
-	wg := &sync.WaitGroup{}
-	wg.Add(2)
-	go c.updateNodeResourceUtilizationMetrics(wg)
-	go c.updateProcessResourceUtilizationMetrics(wg)
-	wg.Wait()
+	c.updateProcessResourceUtilizationMetrics()
 	// aggregate processes' resource utilization metrics to containers, virtual machines and nodes
 	c.AggregateProcessResourceUtilizationMetrics()
 }
 
-// update the node metrics that are not related to aggregated resource utilization of processes
-func (c *Collector) updateNodeResourceUtilizationMetrics(wg *sync.WaitGroup) {
-	wg.Done()
-}
-
-func (c *Collector) updateProcessResourceUtilizationMetrics(wg *sync.WaitGroup) {
-	defer wg.Done()
+func (c *Collector) updateProcessResourceUtilizationMetrics() {
 	// update process metrics regarding the resource utilization to be used to calculate the energy consumption
 	// we first updates the bpf which is responsible to include new processes in the ProcessStats collection
 	resourceBpf.UpdateProcessBPFMetrics(c.bpfExporter, c.ProcessStats)

pkg/kubernetes/watcher.go

@@ -99,15 +99,15 @@ func newK8sClient() *kubernetes.Clientset {
 }
 
 func NewObjListWatcher(bpfSupportedMetrics bpf.SupportedMetrics) (*ObjListWatcher, error) {
-	w := &ObjListWatcher{
+	w := ObjListWatcher{
 		stopChannel:         make(chan struct{}),
 		k8sCli:              newK8sClient(),
 		ResourceKind:        podResourceType,
 		bpfSupportedMetrics: bpfSupportedMetrics,
 		workqueue:           workqueue.NewRateLimitingQueue(workqueue.DefaultControllerRateLimiter()),
 	}
 	if w.k8sCli == nil || !config.IsAPIServerEnabled() {
-		return w, nil
+		return &w, nil
 	}
 	optionsModifier := func(options *metav1.ListOptions) {
 		options.FieldSelector = fields.Set{"spec.nodeName": node.Name()}.AsSelector().String() // to filter events per node
@@ -150,7 +150,7 @@ func NewObjListWatcher(bpfSupportedMetrics bpf.SupportedMetrics) (*ObjListWatche
 		return nil, err
 	}
 	IsWatcherEnabled = true
-	return w, nil
+	return &w, nil
 }
 
 func (w *ObjListWatcher) processNextItem() bool {