fix(ci): run cleanup only on pull requests

This commit fixes the issue where the cleanup job from the mock_acpi workflow was running on any comment to issue or PR. Ideally, it should only run how other jobs in the workflow gets triggered. Signed-off-by: Vibhu Prashar <[email protected]>
sustainable-computing-io · Sep 13, 2024 · d13d50b · d13d50b
1 parent ea93777
commit d13d50b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/.github/workflows/mock_acpi.yml b/.github/workflows/mock_acpi.yml
@@ -50,6 +50,7 @@ jobs:
     if: github.event.issue.pull_request && github.event.comment.body == '/test-acpi'
     name: Test Mock ACPI
     needs: [initalize-workflow, create-runner]
+    continue-on-error: true
     runs-on: self-hosted
     outputs:
       runner-name: ${{ runner.name }}
@@ -87,7 +88,7 @@ jobs:
           ansible-playbook -vv -i inventory.yaml mock_acpi_playbook.yaml -e "pr_number=${{ github.event.issue.number }}"
 
   cleanup:
-    if: ${{ always() }}
+    if: github.event.issue.pull_request && github.event.comment.body == '/test-acpi'
     name: Cleanup
     needs: [initalize-workflow, test-mock-acpi]
     runs-on: ubuntu-latest