test, don't merge: hmc support #1256
Conversation
jiangphcn
force-pushed
the
s390-base
branch
2 times, most recently
from
53246e8 to
58e6f29
Compare
Signed-off-by: Peng Hui Jiang <[email protected]>
|
@jiangphcn release generated in golang-zhmcclient here https://github.com/zhmcclient/golang-zhmcclient/releases/tag/v0.3.0 to support the new function. |
|
thanks @jiangphcn this is really good! Would you be made the PR ready for the next release? |
|
thanks so much @rootfs for your encourage, as always. Yes, I will try my best to make it be ready for next release. |
| type PowerHMC struct{} | ||
|
|
||
| func (a *PowerHMC) GetName() string { | ||
| return "hmc" | ||
| func (r *PowerHMC) GetName() string { |
There was a problem hiding this comment.
should we think about zhmc as it's for z/s390x ?
|
|
||
| func (r *PowerHMC) GetHMCManager() *zhmcclient.ZhmcManager { | ||
| if hmcManager == nil { | ||
| endpoint := os.Getenv("HMC_ENDPOINT") |
There was a problem hiding this comment.
not sure we should add a PREFIX such as Z_ so it will be easier for other platform to know it's for z only?
| } | ||
| energy, _, err := hmcManager.GetEnergyDetailsforLPAR(lparURI, props) | ||
| if err != nil { | ||
| klog.V(1).Infof("Error getting energy data: %v", err.Message) |
|
|
||
| func (r *PowerHMC) GetNodeComponentsEnergy() map[int]source.NodeComponentsEnergy { | ||
| pkgEnergy, _ := r.GetLiveEnergyFromLpar() | ||
| pkgEnergy = pkgEnergy * 3 |
There was a problem hiding this comment.
maybe we can write some info here about why we need this *3
|
@jiangphcn , I have converted this to a draft to indicate WIP. |
|
thank you @sthaha |
No description provided.