chore: cleanup globals in pkg/cgroup

[maryamtahhan]

cleanup globals in pkg/cgroup

[github-actions]

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: This pull request refactors the cgroup package to eliminate global variables, introducing a new cache struct to store container information. The changes improve code organization and reduce coupling between components.

Key Modifications:

1. Global variable removal: Replaced global variables with cache fields, reducing the risk of unintended side effects and improving code maintainability.
2. Cache management functions: Added InitCache(), SetConfig(), and newCache() functions to manage the cache instance, making it easier to initialize and configure the cache.
3. Internal refactoring: Refactored internal functions and variables to use the new cache instance, improving code organization and reducing complexity.

Impact on Codebase:

• Improved code maintainability and organization
• Reduced coupling between components
• Simplified cache management

Observations and Suggestions:

• The changes are mostly internal and do not affect the external interface or behavior of the code.
• It would be beneficial to add unit tests to ensure the new cache implementation works correctly.
• Consider documenting the new cache struct and its management functions to facilitate understanding and usage.

Overall, this pull request improves the codebase's maintainability and organization, making it easier to understand and modify the cgroup package.

[rootfs]

@sthaha @sunya-ch can you take a look? thanks

[sunya-ch]

refactoring by moving all variable to cache struct is fine to me. Just leave some comments.

[sthaha]

requesting changes to consider

• use of init
• remove ensureCacheInitialised
• let cache handle when Mutex should be locked / unlocked

[maryamtahhan]

requesting changes to consider

• use of init
• remove ensureCacheInitialised
• let cache handle when Mutex should be locked / unlocked

Hi @sthaha
I incorporated the suggested changes. Please let me know if there's anything else.

Thanks

[maryamtahhan]

@sthaha sorry to poke again, can you have a look at the updates?

Thanks again

[sthaha]

@sthaha sorry to poke again, can you have a look at the updates?

Thanks again

Sorry, this completely slipped my radar :( ..

[sthaha]

Thanks @maryamtahhan