-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add attestation to container images and SBOMs #1789
Conversation
ref to https://github.com/actions/attest-build-provenance I am not sure if we need additional project configuration for sigstore, @rootfs , could you please advise? |
@SamYuan1990 sounds good, I think removing the attestation from Follow-up question: Is there a reason we are pushing to registry at all for PRs? |
IMO for PR level, https://github.com/sustainable-computing-io/kepler/blob/main/.github/workflows/image_pr.yml#L4 is working with https://quay.io/repository/sustainable_computing_io/kepler?tab=tags&tag=latest which same as image tags you see on quay io. |
Add in-toto attestation to base image ci workflows, for both SBOMs and images themselves upon build and push. Allow necessary permissions to attest (attestations, packages) on these workflows. Signed-off-by: Arthur Savage <[email protected]>
I removed the attestation on PR and restricted permissions where possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the code change look good to me, @arthurus-rex , as |
Add in-toto attestation to all image-building ci workflows, for both SBOMs (image.yml) and images themselves (all 3 workflows). Allow necessary permissions to attest (attestations, packages).