chore: load cpu architecture dependent models #1800
Conversation
Signed-off-by: Huamin Chen <[email protected]>
|
🤖 SeineSailor Here is a concise summary of the pull request changes: Summary: This pull request, "chore: load cpu architecture dependent models", enables loading of CPU architecture-dependent models by introducing a Key Modifications:
Impact: These changes will allow the codebase to load power models based on CPU architecture, potentially affecting the behavior of the code when loading power models. Observations/Suggestions:
|
| cpuArch = strings.TrimSpace(cpuArch) | ||
| fullPath := fmt.Sprintf(`/var/lib/kepler/data/%s/model_weight/%s_%sModel.json`, cpuArch, energySource, modelOutputType) | ||
| // if the model does not exist, return the default model | ||
| if _, err := os.Stat(fullPath); os.IsNotExist(err) { |
There was a problem hiding this comment.
Won't this result in a possible race condition? If you can guarantee that after the os.Stat the file exists, then ignore this comment.
| return fmt.Sprintf(`/var/lib/kepler/data/model_weight/%s_%sModel.json`, energySource, modelOutputType) | ||
| func GetDefaultPowerModelURL(modelOutputType, energySource, cpuArch string) string { | ||
| // strip white space or new line from cpuArch | ||
| cpuArch = strings.TrimSuffix(cpuArch, "\n") |
There was a problem hiding this comment.
TrimSpace should remove \n characters and white space, so you can remove this line
| cpuArch = strings.TrimSpace(cpuArch) | ||
| fullPath := fmt.Sprintf(`/var/lib/kepler/data/%s/model_weight/%s_%sModel.json`, cpuArch, energySource, modelOutputType) | ||
| // if the model does not exist, return the default model | ||
| if _, err := os.Stat(fullPath); os.IsNotExist(err) { |
There was a problem hiding this comment.
On a minor note, os.isNotExist(err) might be misleading as os.Stat can return other types of errors which is not the same as a file/model not existing.
There was a problem hiding this comment.
these files shouldn't change at all 🤔
This is to prepare for coming CPU dependent models