Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compose): Disable idle power metrics in VM #1817

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

vprashar2929
Copy link
Collaborator

@vprashar2929 vprashar2929 commented Oct 21, 2024

This patch disables the idle power metrics produced when Kepler is run
on the VM

Additionally this, patch also updates the version of golangci-lint in pre-commit-config.yaml to fix the failing pre-commit check https://github.com/sustainable-computing-io/kepler/actions/runs/11435710050/job/31811844512

@vprashar2929 vprashar2929 requested a review from sthaha October 21, 2024 07:57
Copy link
Contributor

github-actions bot commented Oct 21, 2024

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: This pull request disables idle power metrics in VM for compose validation.

Key Modifications:

  1. The kepler.config file in manifests/compose/validation/vm/kepler/etc/kepler has been updated to disable idle power metrics.
  2. The .pre-commit-config.yaml file has also been modified to reflect this change.

Impact: This change will prevent idle power metrics from being collected in VM environments during compose validation. This might improve performance or reduce resource utilization, but it's essential to ensure that this metric is not critical for monitoring or debugging purposes.

Observations/Suggestions:

  • It would be helpful to include a brief explanation in the commit message or PR description about the motivation behind disabling idle power metrics.
  • Consider adding a test or validation to ensure that the disablement of idle power metrics does not introduce any unintended consequences.
  • If this change is part of a larger effort to optimize resource utilization, it might be worth exploring other opportunities for improvement in the codebase.

This patch disables the idle power metrics produced when Kepler is run
on the VM

Additionally this, patch also updates the version of golangci-lint in
pre-commit-config.yaml to fix the failing pre-commit check

Signed-off-by: vprashar2929 <[email protected]>
@sthaha sthaha merged commit c08b04a into sustainable-computing-io:main Oct 21, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants