-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move from ubi to ubi-minimal #1825
feat: move from ubi to ubi-minimal #1825
Conversation
🤖 SeineSailor Here is a concise summary of the pull request changes: Summary: This pull request updates the
Impact: These changes do not affect the external interface or behavior of the code, and no alterations to function signatures, global data structures, or variables are observed. The updated base image and package management approach should improve the overall security and efficiency of the Docker image. Observation: The changes are well-contained within the |
cfde359
to
98628ca
Compare
Signed-off-by: MEHDI AICHOUNI <[email protected]>
Signed-off-by: MEHDI AICHOUNI <[email protected]>
fbc643c
to
6a968cd
Compare
@sthaha , would you please start the GHAs? |
@vimalk78 can you take a look? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we need test image at PR level. @rootfs, @marceloamaral , @sthaha could you please help?
@rootfs, @marceloamaral, @sthaha, can you please help with the image test? |
@SamYuan1990 @maichouni-mitek could you please elaborate what you meant by |
@rootfs and I once made a CI job https://github.com/sustainable-computing-io/kepler/actions/workflows/image_pr.yml. The job can build an temp image with a specific PR as code base. As our PR level testing almost running on GHA VM, which is not a BM instance, at meanwhile, this PR has base image change, to ensure the change does not harmful, we can use this PR level CI to build a PR level image and tested on a BM instance if necessary. Well, unfortunately I don't have a BM instance which able to support to test...as my laptop is mac without GPU, so ....that's the reason I comment it out as PR review result in previous. |
LGTM. built images and pushed
|
This PR should close #1826.
Using a smaller base image has several benefits:
kepler
release and another, simply because there are less items installed.A picture is worth a thousand words:
The vulnerabilities we see above (as of 2024/10/24, in
kepler:release-0.7.12
) are inherited from the base image. They are in the python namespace, which is not needed at all in thekepler
image, and which is why #1361 cannot get rid of them.Thank you.