Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compose): switch to stable Prometheus version #1832

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

vprashar2929
Copy link
Collaborator

@vprashar2929 vprashar2929 commented Nov 1, 2024

This commit updates the compose config to use a stable Prometheus version instead of the main development version.
Additionally, it resolves an issue where Prometheus could not scrape metrics from Scaphandre, which was failing due to an invalid Content-Type header in Scaphandre's response.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: This pull request updates the Prometheus version in the Compose configuration from a development version to v2.55.0, resolving an issue with invalid Content-Type headers when scraping metrics from Scaphandre.

Key Modifications:

  • The FROM directive in the Dockerfile is updated to use quay.io/prometheus/prometheus:v2.55.0 instead of quay.io/prometheus/prometheus:main.

Impact: This change is expected to have no impact on the external interface or behavior of the code, as it only updates the Prometheus version. However, it resolves a specific issue with metric scraping from Scaphandre.

Observations/Suggestions: It's a good practice to keep dependencies up-to-date, and this change ensures that the Prometheus version is pinned to a specific release, reducing potential issues with future development versions.

@vprashar2929
Copy link
Collaborator Author

Ref:

Screenshot 2024-11-01 at 7 26 36 PM

@vprashar2929 vprashar2929 requested review from sthaha and rootfs November 1, 2024 13:57
Copy link
Collaborator

@sthaha sthaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use the latest as it point to the latest stable release
https://quay.io/repository/prometheus/prometheus?tab=tags&tag=latest

This commit updates the compose config to use a stable Prometheus version
instead of the main development version.
Additionally, it resolves an issue where Prometheus could not scrape
metrics from Scaphandre, which was failing due to an invalid
`Content-Type` header in Scaphandre's response.

Signed-off-by: vprashar2929 <[email protected]>
@rootfs rootfs merged commit d23e90e into sustainable-computing-io:main Nov 4, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants