Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make validator stressor configuration on runtime and load #1843

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

rootfs
Copy link
Contributor

@rootfs rootfs commented Nov 12, 2024

Setting max runtime so that we can reduce runtime on AWS instances.

@rootfs rootfs requested a review from sthaha November 12, 2024 15:35
@rootfs rootfs marked this pull request as draft November 12, 2024 15:36
Copy link
Contributor

github-actions bot commented Nov 12, 2024

🤖 SeineSailor

Here's a concise summary of the pull request changes:

Summary: This pull request introduces dynamic validator stressor configuration at runtime, allowing for adjustable total runtime and customizable load curves.

Key Modifications:

  1. Added load_curve variable with "default" and "stepwise" options.
  2. Introduced total_runtime_seconds and curve_type configuration options.
  3. Modified Validator class with new stressor attribute and instance variables.
  4. Updated run() function to interact with load_curve variable.

Impact: These changes enhance the internal behavior of the Validator class, making it more flexible and configurable. The external interface remains consistent, ensuring backward compatibility.

Observations:

  • The changes are well-contained within the Validator class and its related modules, minimizing the impact on the broader codebase.
  • The addition of command-line options for total runtime adjustment is a nice touch, providing more flexibility for users.
  • It would be beneficial to include tests that cover the different load curve configurations to ensure the changes work as intended.

Overall, this pull request introduces a valuable feature that enhances the validator's capabilities without disrupting the existing codebase.

@rootfs rootfs force-pushed the validate-aws branch 5 times, most recently from 21d7736 to 7596aa2 Compare November 12, 2024 19:17
@rootfs rootfs marked this pull request as ready for review November 12, 2024 21:03
@sthaha sthaha merged commit 9f9aefb into sustainable-computing-io:main Nov 13, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants