-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix wrong stressor init in validator #1844
Conversation
🤖 SeineSailor Here is a concise summary of the pull request changes: Summary: This pull request enhances the stress testing functionality in the validator by introducing two new parameters, Key Modifications:
Impact: These changes facilitate more comprehensive stress testing and correct the stressor initialization in the validator. Observations/Suggestions:
|
c471dd8
to
9e07a8b
Compare
Signed-off-by: Huamin Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# ruff: noqa: S108 (Suppressed hard-coded path because we want to intentionally copy stress.sh inside `/tmp` dir) | ||
target_script = "/tmp/stress.sh" | ||
cli_options = f"-t {self.total_runtime_seconds} -c {self.curve_type}" | ||
cli_options = " ".join([f"-{k} {v}" for k, v in kwargs.items()]) if kwargs else "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
this is to fix the previous PR that didn't get full tested. This change is verified with the following config: