Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TLS endpoint to kepler exporter #1899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add TLS endpoint to kepler exporter #1899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 49 additions & 1 deletion cmd/exporter/exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import (
"github.com/sustainable-computing-io/kepler/pkg/sensors/accelerator"
"github.com/sustainable-computing-io/kepler/pkg/sensors/components"
"github.com/sustainable-computing-io/kepler/pkg/sensors/platform"
"gopkg.in/yaml.v3"

"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promhttp"
Expand All @@ -51,6 +52,15 @@ const (
startedMsg = "Started Kepler in %s"
)

type TLSConfig struct {
CertFile string `yaml:"cert_file"`
KeyFile string `yaml:"key_file"`
}

type TLSServerConfig struct {
TLSConfig TLSConfig `yaml:"tls_server_config"`
}

// AppConfig holds the configuration info for the application.
type AppConfig struct {
BaseDir string
Expand All @@ -66,6 +76,7 @@ type AppConfig struct {
ExposeEstimatedIdlePower bool
MachineSpecFilePath string
DisablePowerMeter bool
TLSFilePath string
}

func newAppConfig() *AppConfig {
Expand All @@ -84,6 +95,7 @@ func newAppConfig() *AppConfig {
flag.BoolVar(&cfg.ExposeEstimatedIdlePower, "expose-estimated-idle-power", false, "Whether to expose the estimated idle power as a metric")
flag.StringVar(&cfg.MachineSpecFilePath, "machine-spec", "", "path to the machine spec file in json format")
flag.BoolVar(&cfg.DisablePowerMeter, "disable-power-meter", false, "whether manually disable power meter read and forcefully apply the estimator for node powers")
flag.StringVar(&cfg.TLSFilePath, "web.config.file", "", "path to TLS web config file")

return cfg
}
Expand Down Expand Up @@ -181,6 +193,32 @@ func main() {
metricPathConfig := config.GetMetricPath(appConfig.MetricsPath)
bindAddressConfig := config.GetBindAddress(appConfig.Address)

var certFile, keyFile string
tlsConfigured := false

// Retrieve the TLS config
if appConfig.TLSFilePath != "" {
configPath := appConfig.TLSFilePath

configFile, err := os.Open(configPath)
if err != nil {
klog.Errorf("Error opening config file: %v\n", err)
}
defer configFile.Close()

var tlsServerConfig TLSServerConfig
decoder := yaml.NewDecoder(configFile)
if err := decoder.Decode(&tlsServerConfig); err != nil {
klog.Errorf("Error parsing config file: %v\n", err)
}

if tlsServerConfig.TLSConfig.CertFile != "" && tlsServerConfig.TLSConfig.KeyFile != "" {
certFile = tlsServerConfig.TLSConfig.CertFile
keyFile = tlsServerConfig.TLSConfig.KeyFile
tlsConfigured = true
}
}

handler := http.ServeMux{}
reg := m.PrometheusCollector.RegisterMetrics()
handler.Handle(metricPathConfig, promhttp.HandlerFor(
Expand All @@ -207,7 +245,17 @@ func main() {
wg.Add(1)
go func() {
defer wg.Done()
if err := srv.ListenAndServe(); err != nil && !errors.Is(err, http.ErrServerClosed) {
if tlsConfigured {
// Run server in TLS mode
klog.Infof("Starting server with TLS")
err = srv.ListenAndServeTLS(certFile, keyFile)
} else {
// Fall back to non-TLS mode
klog.Infof("Starting server without TLS")
err = srv.ListenAndServe()
}

if err != nil && !errors.Is(err, http.ErrServerClosed) {
errChan <- err
}
}()
Expand Down
Loading