Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/backstage auth info #852

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

jkleinlercher
Copy link
Contributor

@jkleinlercher jkleinlercher commented Nov 18, 2024

solves #100

backstage-resources/docs/grc/backstage_auth.md Outdated Show resolved Hide resolved
backstage-resources/docs/grc/backstage_auth.md Outdated Show resolved Hide resolved
callbackUrl: https://<backstageurl>/api/auth/oidc/handler/frame
clientId: backstage
```
GitHub secrets created by oauth app, alternativly they can get created by GitHub App:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Github secrets GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET are created by oauth app. Alternatively they can get created by GitHub App:"

For me, this sentence was confusing in the first place. So I just tried to rephrase it a little bit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adapted

backstage-resources/docs/grc/backstage_auth.md Outdated Show resolved Hide resolved
backstage-resources/docs/grc/backstage_auth.md Outdated Show resolved Hide resolved
backstage-resources/docs/grc/backstage_auth.md Outdated Show resolved Hide resolved
backstage-resources/docs/grc/backstage_auth.md Outdated Show resolved Hide resolved
backstage-resources/docs/grc/backstage_auth.md Outdated Show resolved Hide resolved
backstage-resources/docs/grc/backstage_auth.md Outdated Show resolved Hide resolved
backstage-resources/docs/grc/backstage_auth.md Outdated Show resolved Hide resolved
Copy link

Changes Default Values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants