-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/backstage auth info #852
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: phac008 <[email protected]>
Signed-off-by: phac008 <[email protected]>
Signed-off-by: phac008 <[email protected]>
Signed-off-by: phac008 <[email protected]>
Signed-off-by: phac008 <[email protected]>
callbackUrl: https://<backstageurl>/api/auth/oidc/handler/frame | ||
clientId: backstage | ||
``` | ||
GitHub secrets created by oauth app, alternativly they can get created by GitHub App: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Github secrets GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET are created by oauth app. Alternatively they can get created by GitHub App:"
For me, this sentence was confusing in the first place. So I just tried to rephrase it a little bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adapted
Signed-off-by: phac008 <[email protected]>
Changes Default Values |
solves #100