Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/s3 #868

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Fix/s3 #868

merged 3 commits into from
Nov 25, 2024

Conversation

phac008
Copy link
Contributor

@phac008 phac008 commented Nov 25, 2024

No description provided.

@phac008 phac008 merged commit cdf1a2f into main Nov 25, 2024
6 checks passed
Copy link

Changes Default Values

Copy link

Changes Rendered Chart
diff -U 4 -r out/target/loki/values-uibklab.yaml/sx-loki/charts/loki/templates/config.yaml out/pr/loki/values-uibklab.yaml/sx-loki/charts/loki/templates/config.yaml
--- out/target/loki/values-uibklab.yaml/sx-loki/charts/loki/templates/config.yaml	2024-11-25 20:56:08.392222427 +0000
+++ out/pr/loki/values-uibklab.yaml/sx-loki/charts/loki/templates/config.yaml	2024-11-25 20:55:42.372024675 +0000
@@ -30,9 +30,9 @@
       storage:
         s3:
           access_key_id: ${ACCESSKEYID}
           bucketnames: ${BUCKETNAME}
-          endpoint: https://"${ENDPOINT}"
+          endpoint: https://${ENDPOINT}
           http_config:
             ca_file: /var/loki-tls/ca.crt
             insecure_skip_verify: false
           insecure: false
@@ -81,9 +81,9 @@
       storage:
         s3:
           access_key_id: ${ACCESSKEYID}
           bucketnames: ${BUCKETNAME}
-          endpoint: https://"${ENDPOINT}"
+          endpoint: https://${ENDPOINT}
           http_config:
             ca_file: /var/loki-tls/ca.crt
             insecure_skip_verify: false
           insecure: false
diff -U 4 -r out/target/loki/values-uibklab.yaml/sx-loki/charts/loki/templates/single-binary/statefulset.yaml out/pr/loki/values-uibklab.yaml/sx-loki/charts/loki/templates/single-binary/statefulset.yaml
--- out/target/loki/values-uibklab.yaml/sx-loki/charts/loki/templates/single-binary/statefulset.yaml	2024-11-25 20:56:08.396222456 +0000
+++ out/pr/loki/values-uibklab.yaml/sx-loki/charts/loki/templates/single-binary/statefulset.yaml	2024-11-25 20:55:42.376024706 +0000
@@ -32,9 +32,9 @@
       app.kubernetes.io/component: single-binary
   template:
     metadata:
       annotations:
-        checksum/config: 0d5f3b89b919e3197da0d628462297c41a2deedc36ecef645756aa277121f4e2
+        checksum/config: a065024f3663b351e522023ac7e3a44b8a61608de2555104d7cc6033cf6b34da
       labels:
         app.kubernetes.io/name: loki
         app.kubernetes.io/instance: release-name
         app.kubernetes.io/component: single-binary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant