clean up jetbrain nullable annotation (apache#13427)

suyashpatel98 · Jun 18, 2024 · 10186f4 · 10186f4
1 parent 8f4ea55
commit 10186f4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/.../test/java/org/apache/pinot/integration/tests/models/DummyTableUpsertMetadataManager.java b/.../test/java/org/apache/pinot/integration/tests/models/DummyTableUpsertMetadataManager.java
@@ -23,6 +23,7 @@
 import java.util.Collections;
 import java.util.Iterator;
 import java.util.Map;
+import javax.annotation.Nullable;
 import org.apache.pinot.segment.local.data.manager.TableDataManager;
 import org.apache.pinot.segment.local.indexsegment.immutable.ImmutableSegmentImpl;
 import org.apache.pinot.segment.local.upsert.BasePartitionUpsertMetadataManager;
@@ -92,9 +93,8 @@ protected long getNumPrimaryKeys() {
 
     @Override
     protected void doAddOrReplaceSegment(ImmutableSegmentImpl segment, ThreadSafeMutableRoaringBitmap validDocIds,
-        @org.jetbrains.annotations.Nullable ThreadSafeMutableRoaringBitmap queryableDocIds,
-        Iterator<RecordInfo> recordInfoIterator, @org.jetbrains.annotations.Nullable IndexSegment oldSegment,
-        @org.jetbrains.annotations.Nullable MutableRoaringBitmap validDocIdsForOldSegment) {
+        @Nullable ThreadSafeMutableRoaringBitmap queryableDocIds, Iterator<RecordInfo> recordInfoIterator,
+        @Nullable IndexSegment oldSegment, @Nullable MutableRoaringBitmap validDocIdsForOldSegment) {
     }
 
     @Override

diff --git a/...main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufCodeGenMessageDecoder.java b/...main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufCodeGenMessageDecoder.java
@@ -29,11 +29,11 @@
 import java.util.Arrays;
 import java.util.Map;
 import java.util.Set;
+import javax.annotation.Nullable;
 import org.apache.pinot.plugin.inputformat.protobuf.codegen.MessageCodeGen;
 import org.apache.pinot.spi.data.readers.GenericRow;
 import org.apache.pinot.spi.stream.StreamMessageDecoder;
 import org.codehaus.janino.SimpleCompiler;
-import org.jetbrains.annotations.Nullable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

diff --git a/.../java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufCodeGenMessageDecoderTest.java b/.../java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufCodeGenMessageDecoderTest.java
@@ -27,7 +27,6 @@
 import java.util.Map;
 import java.util.Set;
 import org.apache.pinot.spi.data.readers.GenericRow;
-import org.jetbrains.annotations.NotNull;
 import org.testng.Assert;
 import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;
@@ -348,7 +347,6 @@ private static Set<String> getAllSourceFieldsForComplexType() {
         NULLABLE_BOOL_FIELD, NULLABLE_BYTES_FIELD);
   }
 
-  @NotNull
   private ProtoBufCodeGenMessageDecoder setupDecoder(String name, String value,
       Set<String> sourceFieldsForComplexType)
       throws Exception {