Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated template #38

Closed
wants to merge 2 commits into from
Closed

Conversation

Copy link

@a-grealish a-grealish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix works for me, but the style changes are not needed.

@@ -1,10 +1,10 @@
/* Main page with stikky-footer */
html, body {
height: 100%;
background-color: #fff;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these style changes should be merged with this template fix.

@aemartinez
Copy link
Author

Ups! The style changes were not supposed to end up in the PR, I've opened another PR #39 with the correct changes.

@aemartinez aemartinez closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants