refactor: split functions (#12)

suzuki-shunsuke · Nov 5, 2023 · b69c067 · b69c067
1 parent adc916b
commit b69c067
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/pkg/controller/run.go b/pkg/controller/run.go
@@ -16,6 +16,14 @@ func (c *Controller) Run(_ context.Context, _ *logrus.Entry, param *ParamRun, vo
 	}
 
 	providers := make(map[string]version.Constraints, len(cfg.Providers))
+	if err := parseConfig(cfg, providers); err != nil {
+		return err
+	}
+
+	return validate(vout, providers)
+}
+
+func parseConfig(cfg *Config, providers map[string]version.Constraints) error {
 	for _, provider := range cfg.Providers {
 		if provider.Name == "" {
 			return ErrProviderNameIsRequired
@@ -33,7 +41,10 @@ func (c *Controller) Run(_ context.Context, _ *logrus.Entry, param *ParamRun, vo
 		}
 		providers[provider.Name] = constraints
 	}
+	return nil
+}
 
+func validate(vout *TerraformVersionOutput, providers map[string]version.Constraints) error {
 	for providerName, providerVersion := range vout.ProviderSelections {
 		constraints, ok := providers[providerName]
 		if !ok {