Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Make inclusion of autoload independent from current working directory #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timint
Copy link

@timint timint commented Aug 24, 2021

No description provided.

@alexanderwiden95
Copy link
Collaborator

Since the structure still is relative to the current working directory we don't really see how this is making any difference with or without __DIR__. Could you elaborate?

@timint
Copy link
Author

timint commented Sep 6, 2021

Yeah, in CLI it will try to access the folder of the command prompt.
I used composer and executed the CLI command:

php example\yadayada.php and it aborted with a fatal error.

I don't see a purpose why it must locked to a certain CWD.

Do you see a problem with making CWD irrelevant?

@alexanderwiden95
Copy link
Collaborator

There is no problem with adding __DIR__, we just didn't expect anyone to use this from an CLI. We'll include this in the example files later on

@timint
Copy link
Author

timint commented Sep 7, 2021

Wonderful to hear 👍.
CLI is an excellent way for testing the examples. I made so much use of it.

The next thing is adding PHP_EOL and strip_tags to the output. I will do a recommendation in another ticket for that.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants