Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code reuse for Spreadsheet and XML writers #97

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

sveinungf
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 98.61111% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.79%. Comparing base (50b9e89) to head (fd7c2f6).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
SpreadCheetah/Helpers/ZipArchiveManager.cs 96.77% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   91.99%   91.79%   -0.20%     
==========================================
  Files         152      152              
  Lines        5584     5497      -87     
  Branches      934      918      -16     
==========================================
- Hits         5137     5046      -91     
+ Misses        213      212       -1     
- Partials      234      239       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 4, 2025

Test Results

     9 files  ±0       9 suites  ±0   11m 55s ⏱️ + 1m 55s
 4 549 tests ±0   4 549 ✅ ±0  0 💤 ±0  0 ❌ ±0 
13 341 runs  ±0  13 341 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fd7c2f6. ± Comparison against base commit 50b9e89.

@sveinungf sveinungf merged commit 1f8798a into main Jan 4, 2025
4 checks passed
@sveinungf sveinungf deleted the dev/spreadsheet-code-reuse branch January 11, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant