add icons #2
Open
add icons #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindrones
approved these changes
May 13, 2019
mindrones
approved these changes
May 13, 2019
README.md
Outdated
|
|
||
| ## License | ||
|
|
||
| []() |
There was a problem hiding this comment.
Yeah. I'm unsure about this and asked in the comment.
There was a problem hiding this comment.
Oops, right, sorry.
I had a look at creative commons (https://creativecommons.org/choose/):
- if you don't want others to derive anything from the logos there's CC BY-NC-ND 4.0, that is Attribution-NonCommercial-NoDerivatives 4.0 International;
- if you're ok with others making new things with the logos there's CC BY-NC-SA 4.0, that is Attribution-NonCommercial-ShareAlike 4.0 International.
mindrones
reviewed
May 18, 2019
| * Either 1x or 4x resolution | ||
| * .png or .svg | ||
|
|
||
|  |
There was a problem hiding this comment.
I think it should be  so that it works independently from the branch we're in.
| - use `svelte-vertical` if your Layout isn't suited a for the use of `svelte-horizontal` | ||
| - for print you'll have to separate the colors from RGB to 4c yourself, according to your print-process | ||
|
|
||
|  |
There was a problem hiding this comment.
and here 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#closes #1
Hey,
pffhheeww, sorry for taking this long, but Adobe Illustrator punished me for using symbols.
Took some time to figure this out.
It's possible to shave some bits of the .svgs by handcrafting out title-attributes and g-tags if wished.
I'll do that, but want to ask first.
Native speakers: run through the README and feel free to correct where necessary.
concerning icons in Text-editors
I saw on vscode-icons #2033 that there are added Icons already. Does that mean, the extension-providers care of that themselves?
Or do WE have to open pull-requests on all the different icon-extensions (there are quite a few, having a look at
vscodeVisual Studio Code alone)concerning license
I'm a bit unsure, if running under MIT means, that everybody is able to use/abuse our Logo?
Hopefully someone who has a clue can help with this.