fix: handle satisfies keyword for vite.addPlugin
#653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 234c12c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
manuel3108
requested changes
Jul 28, 2025
packages/core/tooling/js/vite.ts
Outdated
|
|
||
| // Handle wrapper functions (e.g., defineConfig({})) if ignoreWrapper is specified | ||
| let configObject: AstTypes.ObjectExpression; | ||
|
|
||
| // Handle TypeScript satisfies expressions | ||
| let rootObject = _rootObject; |
There was a problem hiding this comment.
Having rootObject and _rootObject seems unintuitive, Why not change the const to a let above? or find a better name
There was a problem hiding this comment.
I think that I prefer to keep const and we don't want to change it after.
But, you are right, the way done today is not perfect ;)
I'll push something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #652