[fix] add kit to ssr.noExternal in dev mode (#2332)

sveltejs · Aug 31, 2021 · b11679d · b11679d
1 parent bb80006
commit b11679d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/witty-maps-pull.md b/.changeset/witty-maps-pull.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+Add `@sveltejs/kit` to `noExternal` in dev server as well
diff --git a/packages/kit/src/core/dev/index.js b/packages/kit/src/core/dev/index.js
@@ -167,8 +167,12 @@ class Watcher extends EventEmitter {
 				}
 			},
 			ssr: {
-				// @ts-expect-error - ssr is considered in alpha, so not yet exposed by Vite
-				noExternal: [...((vite_config.ssr && vite_config.ssr.noExternal) || []), ...svelte_packages]
+				noExternal: [
+					'@sveltejs/kit', // TODO: see https://github.com/vitejs/vite/issues/3953
+					// @ts-expect-error - ssr is considered in alpha, so not yet exposed by Vite
+					...((vite_config.ssr && vite_config.ssr.noExternal) || []),
+					...svelte_packages
+				]
 			},
 			base: this.config.kit.paths.assets.startsWith('/') ? `${this.config.kit.paths.assets}/` : '/'
 		});