Update AudioPlayer.svelte: fix: begin playing sound again on ended #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marfrede is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
Bug: on:ended the time was set to 0 but after the audio/video ends the audio/video is paused automatically. Fix: on:ended the audio/video needs to be unpaused again.
// for showcase it could also be like below, but the time is set to beginning automatically when audio is unpaused after it ended
time = 0;
paused = false; |
|
Thank you but this isn't desirable behaviour. If you want audio to loop, using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: on:ended the time was set to 0 but after the audio/video ends the audio/video is paused automatically.
Fix: on:ended the audio/video needs to be unpaused again.