Skip to content
This repository has been archived by the owner on Oct 13, 2022. It is now read-only.

Adding meta description, apple-touch-icon, and maskable icon #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edjw
Copy link

@edjw edjw commented Sep 7, 2020

The current starting Sapper template has some things missing for a 100s Lighthouse score. This PR fixes those issues

@mcmxcdev
Copy link
Contributor

mcmxcdev commented Sep 7, 2020

I am pretty sure you shouldn't set meta description in the template.html, because other routes cannot overwrite it with svelte:head. You end up with multiple meta description tags in your head.

@edjw
Copy link
Author

edjw commented Sep 7, 2020

I am pretty sure you shouldn't set meta description in the template.html, because other routes cannot overwrite it with svelte:head. You end up with multiple meta description tags in your head.

Is the _layout.svelte file in /src/routes a better spot for that within a svelte:head block?

@benmccann
Copy link
Member

You can test, but I still don't think it'd overwrite it. I think it's best to include in each individual route

@benmccann
Copy link
Member

@edjw this PR will need to be rebased

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants