explicit closing tags (#288)

sveltejs · May 11, 2024 · 63e5575 · 63e5575
1 parent 6aad025
commit 63e5575
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/pink-terms-sit.md b/.changeset/pink-terms-sit.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/site-kit': patch
+---
+
+fix: add explicit closing tags
diff --git a/packages/site-kit/src/lib/components/Shell.svelte b/packages/site-kit/src/lib/components/Shell.svelte
@@ -54,7 +54,7 @@ The main shell of the application. It provides a slot for the top navigation, th
 	<slot name="top-nav" />
 {/if}
 
-<div class="modal-overlay" class:visible={$overlay_open} aria-hidden="true" />
+<div class="modal-overlay" class:visible={$overlay_open} aria-hidden="true"></div>
 
 <main id="main" bind:this={main_el}>
 	<slot />

diff --git a/packages/site-kit/src/lib/components/ToggleButton.svelte b/packages/site-kit/src/lib/components/ToggleButton.svelte
@@ -6,7 +6,7 @@
 	export let label;
 </script>
 
-<button aria-pressed={pressed} aria-label={label} on:click={() => (pressed = !pressed)} />
+<button aria-pressed={pressed} aria-label={label} on:click={() => (pressed = !pressed)}></button>
 
 <style>
 	button {

diff --git a/packages/site-kit/src/lib/nav/PreloadingIndicator.svelte b/packages/site-kit/src/lib/nav/PreloadingIndicator.svelte
@@ -40,7 +40,7 @@
 {/if}
 
 {#if $p >= 0.4}
-	<div class="fade" />
+	<div class="fade"></div>
 {/if}
 
 <style>

diff --git a/packages/site-kit/src/lib/search/SearchBox.svelte b/packages/site-kit/src/lib/search/SearchBox.svelte
@@ -128,7 +128,7 @@ It appears when the user clicks on the `Search` component or presses the corresp
 />
 
 {#if $searching && ready}
-	<div class="pseudo-overlay" aria-hidden="true" on:click={close} />
+	<div class="pseudo-overlay" aria-hidden="true" on:click={close}></div>
 
 	<!-- svelte-ignore a11y-no-static-element-interactions -->
 	<div