Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore sass deprecation warning #657

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Sep 26, 2024

Quick fix for now, in the mid term we should add proper support for the new API. @kaisermann if you remember what you did back then and how it translates to the new API, I would be grateful for a PR 😄

fixes #656

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to run pnpm lint!)

Tests

  • Run the tests with npm test or pnpm test

Quick fix for now, in the mid term we should add proper support for the new API

fixes #656
@dummdidumm dummdidumm merged commit 9b54325 into main Sep 26, 2024
20 checks passed
@dummdidumm dummdidumm deleted the legacy-sass-silence branch September 26, 2024 11:31
@kaisermann
Copy link
Member

@dummdidumm been a while, but IIRC I couldn't refactor to the new API because some tests randomly started to fail in windows-based CIs 🤔 Will have a look at this this week or on the next! Thanks for pinging me 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPRECATION WARNING: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
2 participants