Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

advent of svelte banner #914

Merged
merged 1 commit into from
Dec 2, 2024
Merged

advent of svelte banner #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions apps/svelte.dev/src/routes/+layout.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,18 @@ const sections: Record<string, string> = {
};

const banner: BannerData = {
id: 'sveltehack2024',
start: new Date('22 Oct, 2024 00:00:00 UTC'),
end: new Date('15 December, 2024 23:59:59 UTC'),
id: 'adventofsvelte2024',
start: new Date('1 December, 2024 00:00:00 UTC'),
end: new Date('25 December, 2024 23:59:59 UTC'),
arrow: true,
content: {
lg: 'Cast runes, win prizes: SvelteHack 2024',
sm: 'SvelteHack 2024'
lg: 'Twenty-four days, twenty-four features: Advent of Svelte 2024',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason to have the numbers written out?

Suggested change
lg: 'Twenty-four days, twenty-four features: Advent of Svelte 2024',
lg: '24 days, 24 features: Advent of Svelte 2024',

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It matches the subtitle on the blog post, so either both should change or neither. Personally I vote neither, but do you have a view?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

sm: 'Advent of Svelte 2024'
},
href: 'https://hack.sveltesociety.dev/2024'
href: '/blog/advent-of-svelte'
};

export const load = async ({ url, fetch }) => {
export const load = async ({ url }) => {
const nav_title = sections[url.pathname.split('/')[1]!] ?? '';

return {
Expand Down
Loading