Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistently set value to blank string when value attribute is undefined #15057

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theodorejb
Copy link
Contributor

Previously there was an inconsistency where a value attribute (correctly) wasn't set if initially undefined (resulting in the input value being a blank string), but if the value attribute was first set to something else, and then changed to undefined, the input value was "undefined" rather than the expected empty string.

Fixes #4467

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-15057-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15057

Copy link

changeset-bot bot commented Jan 19, 2025

⚠️ No Changeset found

Latest commit: fd9dbd2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined value on input and other elements
2 participants