Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3165 fix out transition #3166

Closed
wants to merge 1 commit into from
Closed

3165 fix out transition #3166

wants to merge 1 commit into from

Conversation

matyunya
Copy link

@matyunya matyunya commented Jul 3, 2019

#3165

Fix for broken out page transition when outro.callbacks is undefined.

Copy link

@neurosoup neurosoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (outroing.has(block) || !outros || !outros.callbacks) return;

should be more secure. ;)

@matyunya
Copy link
Author

matyunya commented Jul 4, 2019

Is there a chance for it to get merged either way? I spent a few hours trying to do a proper fix (meaning outros.callbacks is pushed to while outros is undefined, so group_outros has not been called. But looks like it's some really obscure scenario :(

@matyunya
Copy link
Author

matyunya commented Jul 4, 2019

oh, and outros is declared in the upper scope.

@matyunya
Copy link
Author

matyunya commented Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants