tidy up

svencc · Mar 6, 2024 · c8fd1ee · c8fd1ee
1 parent 9f99278
commit c8fd1ee
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 11 deletions.
diff --git a/...mmons/src/main/java/com/recom/commons/calculator/d8algorithm/D8AlgorithmForForestMap.java b/...mmons/src/main/java/com/recom/commons/calculator/d8algorithm/D8AlgorithmForForestMap.java
@@ -68,10 +68,9 @@ private int calculateForestFragment(
                     surroundingForestNeighbourSpaces++;
                 }
             }
-
         }
 
-        int baseColorForest = mapScheme.getBaseColorForest();
+        final int baseColorForest = mapScheme.getBaseColorForest();
 
         if (treeDensity < forestDensityThreshold) {
             return mapScheme.getBaseColorContourBackground(); // @TODO extract to new variable baseColorOfForestBackground!!!

diff --git a/libs/commons/src/main/java/com/recom/commons/map/rasterizer/ForestMapRasterizer.java b/libs/commons/src/main/java/com/recom/commons/map/rasterizer/ForestMapRasterizer.java
@@ -53,7 +53,7 @@ public int[] rasterizeForestMap(
             @NonNull final SpacialIndex<ForestItem> spacialIndex,
             @NonNull final MapDesignScheme mapScheme
     ) {
-        final D8AlgorithmForForestMap d8AlgorithmForForestMap = new D8AlgorithmForForestMap(5.0);
+        final D8AlgorithmForForestMap d8AlgorithmForForestMap = new D8AlgorithmForForestMap(demDescriptor.getStepSize());
 
         final int[][] forestMap = d8AlgorithmForForestMap.generateForestMap(demDescriptor, spacialIndex, mapScheme);
 

diff --git a/...ava/com/recom/commons/map/rasterizer/interpolation/DEMInterpolationAlgorithmBilinear.java b/...ava/com/recom/commons/map/rasterizer/interpolation/DEMInterpolationAlgorithmBilinear.java
@@ -9,10 +9,10 @@ public class DEMInterpolationAlgorithmBilinear implements DEMInterpolationAlgori
 
     @Override
     public float[][] interpolate(
-            @NonNull DEMDescriptor DEMDescriptor,
+            @NonNull DEMDescriptor demDescriptor,
             final int scaleFactor
     ) {
-        return interpolate(DEMDescriptor.getDem(), scaleFactor);
+        return interpolate(demDescriptor.getDem(), scaleFactor);
     }
 
     @Override

diff --git a/services/recom-backend/src/main/java/com/recom/service/map/topography/DEMService.java b/services/recom-backend/src/main/java/com/recom/service/map/topography/DEMService.java
@@ -73,10 +73,4 @@ private DEMDescriptor invertDEM(@NonNull final TopographyData topograpyModel) {
                 .build();
     }
 
-    // warum muss ich das machen? die daten kommen aus einer 3d engine; die koordinaten muss hich hier quasi invertieren
-    // in der 3d engine ist unten links 0,0, ich brauche aber ein 0,0 oben links (image)
-    // ich muss also die daten um 180° drehen; wie mache ich das?
-    // ich iteriere über die daten und schreibe sie in ein neues array; das neue array ist dann um 180° gedreht
-    // gibts da einen algorithmus?
-
 }