Bridge: avoid lexical by upgrading deno_ast, deno_runtime #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasn
previously approved these changes
Oct 5, 2023
`lexical` is a transitive dependency added to the graph bia `deno_ast`. As of `deno_ast` version `0.28.0` they no longer depend on `lexical`. In order to bump `deno_ast` we also need to bump `deno_runtime`. N.b. I looked at bumping us all the way up to the latest for both ast/runtime, but the caused the transformation tests to segfault, so... I'm deferring that effort. For now, I'm bringing us to the smallest upgrade that also avoids the security issue. Also updates the rust cache action - this fixed the "no space left on device" issue we had on the server CI job. Hope it works here too. Refs: https://github.com/svix/svix-webhooks/security/dependabot/66
svix-onelson
force-pushed
the
onelson/depbot-lexical
branch
from
78c8a46 to
7c1360b
Compare
svix-aaron1011
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lexicalis a transitive dependency added to the graph viadeno_ast. As ofdeno_astversion0.28.0they no longer depend onlexical.In order to bump
deno_astwe also need to bumpdeno_runtime.N.b. I looked at bumping us all the way up to the latest for both ast/runtime, but the caused the transformation tests to segfault, so... I'm deferring that effort. For now, I'm bringing us to the smallest upgrade that also avoids the security issue.
Refs: https://github.com/svix/svix-webhooks/security/dependabot/66