Libs(JS): downgrade @stablelib/base64 avoiding ERR_REQUIRE_ESM
#1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1505 Big thanks to @ZONGMENG-kaito for the report. During the work on #1480 various dependencies were updated to match what is being produced by the upstream code generator. Unfortunately, the version spec change for `@stablelib/base64` up to 2.x means we inherit their ESM requirement. The local tests (i.e. `SVIX_SERVER_URL=... SVIX_TOKEN=... yarn test`) continue to pass with the downgrade, so it seems like pinning to 1.x for now will free consumers of _our lib_ of this new requirement for now. Hopefully in the future we'll find a way to track 2.x without disruption.
svix-jplatte
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1505
Big thanks to @ZONGMENG-kaito for the report.
During the work on #1480 various dependencies were updated to match what is being produced by the upstream code generator. Unfortunately, the version spec change for
@stablelib/base64up to 2.x means we inherit their ESM requirement.The local tests (i.e.
SVIX_SERVER_URL=... SVIX_TOKEN=... yarn test) continue to pass with the downgrade, so it seems like pinning to 1.x will free consumers of our lib of this new requirement for now.Hopefully in the future we'll find a way to track 2.x without disruption.