Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch python tests to use public release image #1649

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

svix-mman
Copy link
Contributor

When running the python tests, the svix server docker image is executed.
Instead of building the server from scratch each time, use the publicly released image.

@svix-mman svix-mman requested a review from a team as a code owner January 20, 2025 14:23
@svix-jplatte
Copy link
Member

Not sure what's happening with the test failures, but we're definitely still building the docker image here, but as part of the Python test. I think python/tests/docker-compose.override.yml needs to be adjusted to override the dependency on server/Dockerfile with the upstream image.

@svix-mman
Copy link
Contributor Author

svix-mman commented Jan 20, 2025

Not sure what's happening with the test failures, but we're definitely still building the docker image here, but as part of the Python test. I think python/tests/docker-compose.override.yml needs to be adjusted to override the dependency on server/Dockerfile with the upstream image.

I suspect the same, the startup time for this test is till very slow!
I will look into this.

@svix-mman svix-mman force-pushed the mendy/switch-python-tests-to-public-release branch from 5cd142e to d7ea992 Compare January 20, 2025 16:53
@svix-mman svix-mman force-pushed the mendy/switch-python-tests-to-public-release branch from d7ea992 to 3833469 Compare January 20, 2025 17:07
@svix-jplatte svix-jplatte merged commit e2143fb into main Jan 20, 2025
8 checks passed
@svix-jplatte svix-jplatte deleted the mendy/switch-python-tests-to-public-release branch January 20, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants