Upgrade the version of timew-report
#14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonafato
force-pushed
the
update-timew-report-dependency
branch
from
239afee
to
5ceb6de
Compare
The version of `timew-report` was restricted in sw00#10 to deal with failing tests. This change updates the version required by the `Pipfile` and makes the following code changes: 1. Update a test helper to pass in a value for the new required argument `annotation`. This is not used by the test suite, so the helper uses `None` for now. 2. Addresses some breaking changes and deprecation warnings in `get_date` released in [1.4]. `get_date` now returns a `date` instead of a `datetime`. `get_start_date` offers the same implementation that `get_date` used to, so no logic has changed here, and this avoids deprecation warnings. [1.4]: lauft/timew-report@a964eb3
jonafato
force-pushed
the
update-timew-report-dependency
branch
from
5ceb6de
to
5b437ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of
timew-reportwas restricted in #10 to deal with failingtests. This change updates the version required by the
Pipfileandmakes the following code changes:
Update a test helper to pass in a value for the new required argument
annotation. This is not used by the test suite, so the helper usesNonefor now.Addresses some breaking changes and deprecation warnings in
get_datereleased in 1.4.get_datenow returns adateinsteadof a
datetime.get_start_dateoffers the same implementation thatget_dateused to, so no logic has changed here, and this avoidsdeprecation warnings.
Note that this pull request is branched from #13. These changes aren't actually related, but I wanted a stable testing state to base this upgrade on. The diff against
masterwill be smaller once that other change is merged.