Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from deprecated openjdk to eclipse-temurin #12470

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Sep 25, 2024

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. Not needed I'd say
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. Not needed I'd say

Description of the PR

The OpenJDK images have long been deprecated (see https://hub.docker.com/_/openjdk) and are built on top of EOL'd Alpine versions.

⚒️ with ❤️ by Siemens

The OpenJDK images have long been deprecated (see https://hub.docker.com/_/openjdk) and are built on top of EOL'd Alpine versions
@fgreinacher fgreinacher marked this pull request as ready for review September 25, 2024 14:33
@fgreinacher
Copy link
Contributor Author

@frantuma Would you have a look at this? 🙇

@fgreinacher
Copy link
Contributor Author

@frantuma Friendly ping. Let me know if I can perform additional preparation/testing to make reviewing easier. 🙇

@fgreinacher
Copy link
Contributor Author

@frantuma @HugoMario Pinging you again because we really want to avoid forking this just for getting rid of the deprecated JDK 🙇

@frantuma frantuma merged commit 24892dc into swagger-api:master Dec 12, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants