Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth to user routes #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add auth to user routes #54

wants to merge 1 commit into from

Commits on Feb 23, 2021

  1. Add auth to user routes 

    Removed the description on createUser that said only a logged in user can create a user. 
Added auth with no required scopes to log out, update user, and delete user. 

It's not clear to me how security is supposed to work across the API, but these things should at least make it more consistent and sensical. I made a guess that createUser would fill the role of signing up, but it could just as easily been intended to keep the description and make it so that only a logged in user can create another user.   
Requiring a token to log out makes sense, because you'd have to be logged in first.   
Requiring a token to update and delete user makes the security consistent with the operation description.
    @nrktkt
    nrktkt committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    0b17b24 View commit details
    Browse the repository at this point in the history