add include, and exclude is invalid if include is set #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimohunter
changed the title
Codecov Report
@@ Coverage Diff @@
## master #906 +/- ##
==========================================
- Coverage 84.83% 84.05% -0.79%
==========================================
Files 8 8
Lines 1649 1668 +19
==========================================
+ Hits 1399 1402 +3
- Misses 145 159 +14
- Partials 105 107 +2
Continue to review full report at Codecov.
|
|
parser_test.go 3385 pretty nice example for your missing tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
add include , if include is set ,exclude path is invalid.
Relation issue
#905
Additional context
i find struct type define also be ignore by exclude args, so move the skip excloud path function and add include. Welcome to discuss this idea