Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Fix test suite (PHP 8.2 update!) #71

Merged
merged 3 commits into from
Sep 3, 2023
Merged

✅ Fix test suite (PHP 8.2 update!) #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e6b6ef
:white_check_mark: Update test suite
Nek- Sep 3, 2023
7a69ef9
:wrench: Add PHP 8.2 to the CI
Nek- Sep 3, 2023
f45fb0e
:wrench: Attempt to fix composer install in 7.4
Nek- Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.0
php-version: 8.2

- uses: actions/cache@v2
id: cache-composer
with:
path: ~/.composer/cache
key: composer-php-8.0-${{ github.sha }}
restore-keys: composer-php-8.0-
key: composer-php-8.2-${{ github.sha }}
restore-keys: composer-php-8.2-

- name: Install dependencies
run: composer update --prefer-dist --no-progress --no-suggest
Expand All @@ -37,7 +37,7 @@ jobs:
name: Unit tests
strategy:
matrix:
php: [ 8.0, 8.1 ]
php: [ 8.0, 8.1, 8.2 ]
os: [ ubuntu-latest ]
include:
- os: [ ubuntu-latest ]
Expand All @@ -63,7 +63,7 @@ jobs:
run: make test.composer

- name: Install dependencies
run: composer update --prefer-dist --no-progress --no-suggest ${{ matrix.composer-flag }}
run: composer update --prefer-dist --no-progress --no-suggest --no-plugins ${{ matrix.composer-flag }}

- name: Run PHPUnit tests
run: make test.phpunit
Expand All @@ -72,7 +72,7 @@ jobs:
name: Functionnal tests
strategy:
matrix:
php: [ 8.0, 8.1 ]
php: [ 8.0, 8.1, 8.2 ]
os: [ ubuntu-latest ]
include:
- os: [ ubuntu-latest ]
Expand All @@ -97,7 +97,7 @@ jobs:


- name: Install dependencies
run: composer update --prefer-dist --no-progress --no-suggest ${{ matrix.composer-flag }}
run: composer update --prefer-dist --no-progress --no-suggest --no-plugins ${{ matrix.composer-flag }}

- name: Run Behat tests
run: make test.behat
4 changes: 3 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
"doctrine/doctrine-bundle": "^2.1",
"behat/behat": "3.10.0",
"friends-of-behat/symfony-extension": "^2.3.0",
"fakerphp/faker": "^1.12.1"
"fakerphp/faker": "^1.12.1",
"monolog/monolog": "^3.4 || ^2.9",
"masterminds/html5": "^2.8"
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 1 addition & 1 deletion tests/Behat/Context/BasicsContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class BasicsContext extends AbstractContext
*/
public function iMakeARequestOn($uri, $verb = 'GET', PyStringNode $content = null)
{
$this->request($uri, $verb, $content);
$this->request($uri, $verb, (string) $content);
}

/**
Expand Down
Loading