init symfony 7 support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nek-
requested changes
May 31, 2024
There was a problem hiding this comment.
Hello,
This looks great, but is it really compatible with Symfony 5? wow nice!
I'm sorry I saw you transformed all tests already but can you integrate the PHPUnit trait instead ? 🙏
Anyway thank you very much for this work!
side note: I re-enabled the workflow, please be sure the test suite is passing!
apply suggested change for Prophecy trait usage update dependencies switch to xml mapping to avoid annotation/attribute retrocompatibility issues add sqlite extension to ci add missing behat test to makefile command set minimum php version requirement to 8.0 bump dependencies to versions supporting php 8.0 use attribute mapping update readme
Nek-
approved these changes
Jun 4, 2024
|
Thank you very much @Sakonokode ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Nek- Hello, voila une PR qui permet le bump vers symfony 7 et php 8.0