✨ remove super custom code

In previous versions of Doctrine, it was hard to act on entity load. Since doctrine changed its internal behavior, we managed to improve the situation as well on the bundle. The new PostLoadDispatcherInjecttionListener class allows us to remove a huge part of this bundle that was previously super-mega-custom. This is awesome! But it comes with a huge refactoring, and this is not even the last commit toward the next major version of this package.
swagindustries · Jul 29, 2024 · 728e1de · 728e1de
1 parent 6275a32
commit 728e1de
Show file tree

Hide file tree

Showing 26 changed files with 31 additions and 694 deletions.
diff --git a/Tests/Event/DelayedListenerTest.php b/Tests/Event/DelayedListenerTest.php
@@ -7,7 +7,6 @@
 use Biig\Component\Domain\Event\DomainEventDispatcher;
 use Biig\Component\Domain\Exception\InvalidDomainEvent;
 use Biig\Component\Domain\Model\DomainModel;
-use Biig\Component\Domain\PostPersistListener\DoctrinePostPersistListener;
 use Biig\Component\Domain\Rule\PostPersistDomainRuleInterface;
 use Biig\Component\Domain\Tests\fixtures\Entity\FakeModel;
 use Biig\Component\Domain\Tests\SetupDatabaseTrait;
@@ -103,7 +102,7 @@ public function testItDoesNotExecuteManyTimesSameEvent()
     {
         // Test setup
         $dispatcher = new DomainEventDispatcher();
-        $entityManager = $this->setupDatabase($dispatcher, 'testItInsertInBddAfterFlushing');
+        $entityManager = $this->setupDatabase($dispatcher, 'testItDoesNotExecuteManyTimesSameEvent');
 
         $model = new FakeModel();
         $model->setFoo(0);

diff --git a/Tests/Model/Instantiator/DoctrineConfig/ClassMetadataFactoryTest.php b/Tests/Model/Instantiator/DoctrineConfig/ClassMetadataFactoryTest.php
diff --git a/Tests/Model/Instantiator/DoctrineConfig/ClassMetadataTest.php b/Tests/Model/Instantiator/DoctrineConfig/ClassMetadataTest.php
diff --git a/Tests/Model/Instantiator/DoctrineConfig/InstantiatorTest.php b/Tests/Model/Instantiator/DoctrineConfig/InstantiatorTest.php
diff --git a/Tests/PostFlushListener/EntitiesHasDispatcherCheckerTest.php b/Tests/PostFlushListener/EntitiesHasDispatcherCheckerTest.php
@@ -42,7 +42,7 @@ public function testAnEntityThatDoesntHaveDispatcherWhileFlushedThrowAnError()
     {
         self::bootKernel(['debug' => true]);
         // You should not create your entites this way in your own code !
-        // Use the Biig\Component\Domain\Model\Instantiator\Instantiator service to instanciate your entities.
+        // Use the Biig\Component\Domain\Model\Instantiator\Instantiator service to instantiate your entities.
         $model = new FakeModel();
 
         $this->expectException(FlushedEntityDoesntContainsDispatcherException::class);

diff --git a/Tests/SetupDatabaseTrait.php b/Tests/SetupDatabaseTrait.php
@@ -19,7 +19,6 @@ private function setupDatabase(DomainEventDispatcherInterface $dispatcher, strin
         copy(__DIR__ . '/fixtures/dbtest/initial_fake_model.db', $this->dbPath);
 
         $config = ORMSetup::createAttributeMetadataConfiguration(array(__DIR__ . '/../fixtures/Entity'), true);
-        $config->setClassMetadataFactoryName(ClassMetadataFactory::class);
         $conn = [
             'driver' => 'pdo_sqlite',
             'path' => $this->dbPath,
@@ -29,8 +28,6 @@ private function setupDatabase(DomainEventDispatcherInterface $dispatcher, strin
         $entityManager->getEventManager()->addEventSubscriber(new DoctrinePostPersistListener($dispatcher));
         $entityManager->getEventManager()->addEventSubscriber(new PostLoadDispatcherInjectionListener($dispatcher));
 
-        $entityManager->getMetadataFactory()->setDispatcher($dispatcher);
-
         return $entityManager;
     }
 

diff --git a/...pendencyInjection/CompilerPass/InsertDispatcherInClassMetadataFactoryCompilerPassTest.php b/...pendencyInjection/CompilerPass/InsertDispatcherInClassMetadataFactoryCompilerPassTest.php
diff --git a/.../Symfony/DependencyInjection/CompilerPass/VerifyDoctrineConfigurationCompilerPassTest.php b/.../Symfony/DependencyInjection/CompilerPass/VerifyDoctrineConfigurationCompilerPassTest.php
diff --git a/Tests/Symfony/DependencyInjection/DomainExtensionTest.php b/Tests/Symfony/DependencyInjection/DomainExtensionTest.php
@@ -25,6 +25,7 @@ public function testItAddsDoctrinePostPersistListenerToContainer()
         $extension->load($config, $container);
 
         $array = [
+            'biig_domain.postload_subscriber' => [[]],
             "biig_domain.post_persist_listener.doctrine_default" => [
                 [
                     "connection" => "default"

diff --git a/Tests/Symfony/DependencyInjection/EntityManagerConfiguratorTest.php b/Tests/Symfony/DependencyInjection/EntityManagerConfiguratorTest.php
diff --git a/composer.json b/composer.json
@@ -6,7 +6,7 @@
         "php": ">=8.1",
         "symfony/event-dispatcher": "^5.0|^6.0|^7.0",
         "doctrine/doctrine-bundle": "^1.8|^2.0",
-        "doctrine/orm": "^2.6.3"
+        "doctrine/orm": "^2.18.3"
     },
     "authors": [
         {
@@ -16,7 +16,7 @@
     ],
     "require-dev": {
         "phpunit/phpunit": "^9.5 || ^10",
-        "doctrine/orm": "^2.6.3",
+        "doctrine/orm": "^2.18.3",
         "friendsofphp/php-cs-fixer": "^3.49.0",
         "symfony/framework-bundle": "^5.0 || ^6.0",
         "phpspec/prophecy-phpunit": "^2.0.1",