Jh 4 0 #82
Merged
Jh 4 0 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is to be merged, when agreed, together with the corresponding PR of the swan charts: swan-cern/swan-charts#167. We might need to reconsider if this needs to go together with an update of the systemuser image. Therefore, this is on hold for now. |
etejedor
force-pushed
the
jh_4_0
branch
2 times, most recently
from
0aa521d
to
6532313
Compare
diocas
commented
Aug 16, 2023
diocas
force-pushed
the
jh_4_0
branch
3 times, most recently
from
f7fdf88
to
c53f6d5
Compare
This was referenced Aug 16, 2023
Removes User API handler and replaces it with scope configuration Adapt Spawn Handler
Removes extra_env, replaced by upstream config option
No longer need to pass headers to requests (and no longer available) Update readme to replace deprecated config
This overrides the stop method of kubespawner to include some cleanup of secrets and services related to EOS and Spark after the pod has terminated. This was previously done in two post_stop_hook functions defined in swan_config_cern.py and swan_spark_config.py in the swan-cern chart. After moving to an async spawner, that hook can't be used anymore because it can't be a coroutine (it is never awaited). However, the moved code needs to be in a coroutine because it includes calls to the k8s API that need to be awaited. This justifies its transfer to stop, which is a coroutine.
We removed them from systemuser startup
The deletion of the corresponding secret is already done during the stop method of our k8s spawner (this is included in the JH4 upgrade changes). Since the culler asks the hub to cull sessions, the stop method will be called for each of those sessions, and thus the EOS ticket secret will be removed.
etejedor
reviewed
Oct 18, 2023
diocas
commented
Oct 24, 2023
etejedor
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing updates of Kubespawner, that @etejedor will work on.
Ofc this still has things that need to be removed and cleaned, but we need 1st to decomission puppet (to remove the extra user api handler) and to a new image, cleaned of extra, unwanted configs.
Also, once we update the design and user a more upstream look and feel, the overload of the spawner handler is no longer needed.