Fix compilation #28
Merged
Fix compilation #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer ship the Jupyterlab code together with the python module, as it gets directly - and automatically - installed in the final destination.
etejedor
previously approved these changes
Jan 19, 2024
|
@diocas should we have a look at the failed JavaScript check? |
Makes checks pass
etejedor
approved these changes
Jan 19, 2024
|
maybe 3.0.2 or 3.1.0 release ? our usage failed with 3.0.1: we use this command to install |
|
@camper42 we removed version 3.0.1 because of that. This PR should fix the issue. We will tag a new version this Wednesday. |
|
never mind, thank you very much for your work in support of Lab 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned the compilation code with upstream (had to finally try to make it work), and now it builds the frontend components as well (these were being skipped).
Changed the name of the folder of the nbextension from "static" to "nbextension" (the Lab extension was inside "labextension", so it makes more sense this way).
Since the extension gets automatically copied to the final destination (and now the build code doesn't include the lab extension together with the Python module by default), I removed the possibility of manually installing it. This part of the code was (and would continue to) crash, since it was relying on the
package.jsonfile to retrieve the name (which was not necessary, but that's how it was).I believe none of this is necessary, but we can easily add it back.
Needs testing.