Turn Spark pod hook into a generic hook for handling external computing integrations #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diocas
requested changes
Nov 17, 2023
diocas
approved these changes
Nov 20, 2023
The user will decide upon session start if they want to work with an HTCondor cluster. If yes, the corresponding configuration will be done.
Refactor the existing pod modifier hook for Spark to also do the necessary configuration for HTCondor. The motivation to cluster both together is the fact that both computing services require port opening. Thus, one single k8s service with the necessary open ports can serve both. The choice of 18 ports for Spark is kept, and a new choice of 5 ports for HTCondor is introduced, which in practice means that 5 SwanHTCondorClusters can be created -- this should be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to implement a special treatment for HTCondor pools at the level of the modifier pod hook.
Now Spark and HTCondor will share a hook, which will configure both. The reason for this is that both share the need to open ports in the user session. Depending on what the user selects in the form (Spark, HTCondor or both) we will create a k8s service that provides the corresponding ports.