Fix LinkCell missing key (#640)

swan-io · Dec 3, 2024 · 07aa94e · 07aa94e
1 parent e82c811
commit 07aa94e
Show file tree

Hide file tree

Showing 3 changed files with 837 additions and 824 deletions.
diff --git a/.npmrc b/.npmrc
@@ -1,3 +1,4 @@
-node-linker=hoisted
-save-exact=false
 auto-install-peers=false
+lockfile-include-tarball-url=true
+save-exact=false
+node-linker=hoisted
diff --git a/packages/lake/src/components/Cells.tsx b/packages/lake/src/components/Cells.tsx
@@ -358,7 +358,7 @@ export const LinkCell = ({
 }: LinkCellProps) => {
   const atEnd = buttonPosition === "end";
 
-  const elements = [
+  const button = (
     <Pressable
       style={[styles.button, atEnd && styles.buttonEnd]}
       onPress={event => {
@@ -378,18 +378,30 @@ export const LinkCell = ({
           )}
         </>
       )}
-    </Pressable>,
+    </Pressable>
+  );
 
+  const text = (
     <LakeText numberOfLines={1} color={colors.gray[900]} variant={variant} tooltip={tooltip}>
       {children}
-    </LakeText>,
-  ];
-
-  if (atEnd) {
-    elements.reverse();
-  }
+    </LakeText>
+  );
 
-  return <Cell fadeOn={fadeOn}>{elements}</Cell>;
+  return (
+    <Cell fadeOn={fadeOn}>
+      {atEnd ? (
+        <>
+          {text}
+          {button}
+        </>
+      ) : (
+        <>
+          {button}
+          {text}
+        </>
+      )}
+    </Cell>
+  );
 };
 
 /**