Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify and add some hash #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Its-Just-Nans
Copy link

Hello,

Do you know why bytes.rs and mod.rs look the same ?

Test the PR

time cargo run 7c13517e2bd3f4d4dc4c44be73f56c4a7f15caf3776cd68c33f7d6054f2ee919 -b

the -b is important for exact match

@swanandx
Copy link
Owner

swanandx commented Jun 5, 2024

Do you know why bytes.rs and mod.rs look the same ?

Because both are essentially same, only difference being one uses regex::bytes::Regex and later using regex::Regex ( and other fn signature changes )

as regex also has them un different modules, I decided to put bytes related implementation in separate module

Copy link
Owner

@swanandx swanandx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

As this was initially just Rust port of PyWhat, identifying hashes was excluded because that was done by https://github.com/HashPals/Name-That-Hash .

But would be nice if lemmeknow can identify the hases correctly as well haha

src/identifier/mod.rs Outdated Show resolved Hide resolved
src/identifier/mod.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants