Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Semigroup EntityMap instance to update Capabilities map properly when there are overridden devices #2242

Merged
merged 5 commits into from
Dec 31, 2024
Merged

Fix Semigroup EntityMap instance to update Capabilities map properly when there are overridden devices #2242

merged 5 commits into from
Dec 31, 2024

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Dec 28, 2024

Fixes #2240. Fixes the Semigroup EntityMap instance so that devices which are overridden are removed from the lists of devices providing certain capabilities.

@byorgey byorgey requested a review from kostmo December 28, 2024 16:24
@github-actions github-actions bot mentioned this pull request Dec 28, 2024
Closed
kostmo
kostmo approved these changes Dec 31, 2024
View reviewed changes
src/swarm-scenario/Swarm/Game/Entity.hs Outdated Show resolved Hide resolved
@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Dec 31, 2024
@mergify mergify bot merged commit 79ba1b7 into main Dec 31, 2024
14 checks passed
@mergify mergify bot deleted the fix/issue-2240 branch December 31, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostmo kostmo kostmo approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overridden standard entities are still suggested as a means to provide a missing capability
2 participants
@byorgey @kostmo