fix: Skip all transpilation and adding any polyfills when unknown browser version used #10376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
CodSpeed Performance ReportMerging #10376 will improve performances by ×6.9Comparing Summary
Benchmarks breakdown
|
kdy1
requested changes
Apr 15, 2025
| @@ -58,7 +58,7 @@ where | |||
| let f = transform_data::Feature::$feature; | |||
| !exclude.contains(&f) | |||
| && (c.force_all_transforms | |||
| || (is_any_target | |||
| || (!is_any_target | |||
There was a problem hiding this comment.
!is_any_target is wrong way to detect unknown browser version
| @@ -58,7 +58,7 @@ where | |||
| let f = transform_data::Feature::$feature; | |||
| !exclude.contains(&f) | |||
| && (c.force_all_transforms | |||
| || (is_any_target | |||
| || (!is_any_target | |||
There was a problem hiding this comment.
!is_any_target is not a way to detect an unknown browser version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Skip all transpilation and adding any polyfills when unknown browser version used
BREAKING CHANGE:
I need some help. Right now, my approach is:
when an unsupported browser version is set in browserslist-rs — for example:
Because the
targets_to_versionshas theignore_unkonwn_versionsoption enabled inbrowserslist_opts, it ends up returning an empty result, andis_any_targetbecomes true.So, I added a check to skip processing when the
targetslist is empty. But when I runcargo test, not all the tests pass. I'm not sure if there's a problem with my approach, or if I’m missing some edge cases.Related issue (if exists):
#9778