Skip to content

refactor(common): Move stacker dependency to swc_common #10485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented May 19, 2025

No description provided.

@bvanjoi bvanjoi requested review from a team as code owners May 19, 2025 16:19
Copy link

changeset-bot bot commented May 19, 2025

🦋 Changeset detected

Latest commit: bfc0871

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Performance Report

Merging #10485 will degrade performances by 5.8%

Comparing bvanjoi:pref (bfc0871) with main (1298e76)

Summary

⚡ 1 improvements
❌ 7 regressions
✅ 136 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/lints/libs/d3 28.2 ms 27.6 ms +2.32%
es/fixer/typescript 205.4 ms 211.3 ms -2.77%
es/hygiene/typescript 493.5 ms 512.2 ms -3.66%
es/resolver/typescript 250.9 ms 256.3 ms -2.12%
es/resolver_with_hygiene/typescript 842.2 ms 865.2 ms -2.66%
hygiene/typescript 24.4 s 25.3 s -3.54%
resolver/typescript 12.6 s 12.9 s -2.07%
es/transform/baseline/common_typescript 376.5 µs 399.7 µs -5.8%

@kdy1 kdy1 added this to the Planned milestone May 19, 2025
@bvanjoi bvanjoi force-pushed the pref branch 2 times, most recently from 7df2a59 to 636d17c Compare May 21, 2025 16:51
@kdy1
Copy link
Member

kdy1 commented May 22, 2025

To fix CI, I think you need to depend on swc_ecma_parser with default features from the dev-dependencies of swc_ecmascript/Cargo.toml

kdy1
kdy1 previously approved these changes May 22, 2025
@kdy1 kdy1 changed the title chore(es/parser): use stacker in utils refactor(common): Move stacker dependency to swc_common May 22, 2025
@kdy1 kdy1 enabled auto-merge (squash) May 22, 2025 16:19
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you investigate benchmark regression? I think stacker was previously not enabled and it's now enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants