Skip to content

Conversation

gkgoat1
Copy link

@gkgoat1 gkgoat1 commented Jul 29, 2025

Description:

Temporarily undoes if statement compression to allow IIFE inlining of branches. If statements are still recompressed after that occurs.

Solves scenario 2 in #10280 , where an iife can be inlined, but is nested within a ternary expression. By expanding them to if statements, the iife can be inlined before recompressing the statement to another ternary expression.

Related issue (if exists):

#10280

@gkgoat1 gkgoat1 requested a review from a team as a code owner July 29, 2025 16:10
Copy link

changeset-bot bot commented Jul 29, 2025

⚠️ No Changeset found

Latest commit: 0c81538

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests

Copy link

codspeed-hq bot commented Jul 29, 2025

CodSpeed Performance Report

Merging #10957 will not alter performance

Comparing portal-co:pr/more_inlining (0c81538) with main (d160f7f)

Summary

✅ 140 untouched benchmarks

@gkgoat1
Copy link
Author

gkgoat1 commented Jul 30, 2025

Converting to draft due to potential performance issues

@gkgoat1 gkgoat1 marked this pull request as draft July 30, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants