refactor(plugin): Switch plugin abi to flexible serialization #11198

quininer · 2025-10-28T09:32:17Z

Description:

This is a follow up to #11100, which will result in plugin abi break.

It currently passes the plugin tests, but I still need to do some code and configuration cleanup, and add a regression test.

BREAKING CHANGE:

Since we switch serialization schemes, this will result in breaking changes on the plugin abi and api.

Related issue (if exists):

changeset-bot · 2025-10-28T09:32:24Z

⚠️ No Changeset found

Latest commit: f735956

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codspeed-hq · 2025-10-28T09:44:43Z

CodSpeed Performance Report

Merging #11198 will not alter performance

_{Comparing quininer:r/switch-wasm-abi (f735956) with main (6223100)}

Summary

✅ 138 untouched

socket-security · 2025-10-29T09:04:29Z

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

Copilot

Pull Request Overview

This PR migrates the serialization layer from rkyv to cbor4ii encoding for the SWC plugin system. The changes include:

Replacing rkyv-impl feature flags with encoding-impl across multiple crates
Adding cbor4ii as a dependency for serialization/deserialization
Updating field encoding attributes from rkyv-specific to cbor4ii-specific implementations
Modifying CSS AST enum variants from tuple-style to named field syntax (e.g., Token::Dimension(v) → Token::Dimension { dimension: v })
Removing deprecated CSS plugin transform functionality
Updating visitor code generation to handle both tuple and named variant syntax

Reviewed Changes

Copilot reviewed 144 out of 154 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tools/generate-code/src/generators/visitor.rs	Enhanced visitor code generation to support both tuple and named field enum variants
crates/swc_xml_ast/src/*.rs	Added encoding-impl attributes for Option fields using cbor4ii::core::types::Maybe
crates/swc_plugin_runner/src/*.rs	Replaced __rkyv feature with encoding-impl and updated serialization logic
crates/swc_plugin_proxy/src/*.rs	Migrated from rkyv to cbor4ii serialization traits and simplified memory interop
crates/swc_ecma_ast/src/*.rs	Added encoding-impl attributes for TypeScript/JSX optional fields
crates/swc_css_parser/tests/*/.{json,stderr}	Updated test snapshots to reflect new Token::Dimension structure
crates/swc_plugin_macro/src/lib.rs	Removed css_plugin_transform macro

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2025-10-30T08:34:38Z

Binary Sizes

File	Size
`swc.linux-x64-gnu.node`	31M (31930760 bytes)

Commit: c6826db

quininer · 2025-10-30T09:04:48Z

rkyv:

cbor (with unknown):

I ran swc_plugin_backend_tests/benches/ecma_invoke.rs, and the new scheme is about 10% to 25% slower than rkyv scheme.

Copilot

Pull Request Overview

Copilot reviewed 144 out of 154 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull Request Overview

Copilot reviewed 45 out of 51 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-03T01:57:30Z

crates/swc_plugin_backend_tests/tests/wasm_regression.rs

+/// it from the old Wasm plugin (v1), serialize it back as old data (v1), and
+/// deserialize it back from latest runtime (v2).
+#[test]
+fn bakward_compatible() {


Corrected spelling of 'bakward' to 'backward'.

Copilot · 2025-11-03T01:57:31Z

crates/swc_plugin_backend_tests/tests/wasm_regression.rs

+///
+/// This is a test for Wasm plugin tests.
+///
+/// This test simulates serilizing from the latest runtime (v2) and deserialize


Corrected spelling of 'serilizing' to 'serializing'.

Copilot · 2025-11-03T01:57:31Z

crates/swc_common/src/plugin/metadata.rs

+            name: &"Context",
+            found: 0,
+        })?;
+        let len = std::cmp::min(len, 4 * 1024);


The magic number 4 * 1024 should be extracted as a named constant (e.g., const MAX_CONTEXT_ENTRIES: usize = 4096;) to improve code readability and maintainability.

crates/swc_common/src/plugin/serialized.rs

crates/swc_plugin_backend_tests/tests/fixture/swc_internal_plugin/src/lib.rs

kdy1 · 2025-11-03T03:10:04Z

crates/swc_plugin_backend_tests/tests/fixture/.cargo/config.toml

@@ -0,0 +1,4 @@
+[target.wasm32-wasip1]


Can you update the plugin template to have this?

It's located at https://github.com/swc-project/swc/blob/622310055c59ee42b744038a33997e6f43cf4af0/crates/swc_cli_impl/src/commands/plugin.rs

Copilot

Pull Request Overview

Copilot reviewed 48 out of 54 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/ast_node/src/encoding/decode.rs

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 48 out of 54 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/swc_common/src/syntax_pos.rs

crates/ast_node/src/encoding/decode.rs

Copilot

Pull Request Overview

Copilot reviewed 48 out of 54 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/swc_common/src/syntax_pos.rs

crates/ast_node/src/encoding/decode.rs

kdy1 · 2025-11-03T06:27:56Z

Can you reflect some change requests about panic from @Copilot and fix the CI?

quininer · 2025-11-03T06:53:28Z

Copilot provides an illusion-based patch, which we need to revert.

kdy1 · 2025-11-03T07:35:14Z

Thank you so much for the hard work on the idea and implementing it!
I'll think about the way to merge this PR cleanly

quininer force-pushed the r/switch-wasm-abi branch 4 times, most recently from f02f7d4 to 0f85c06 Compare October 29, 2025 09:03

quininer force-pushed the r/switch-wasm-abi branch 2 times, most recently from d043f9f to 119000c Compare October 29, 2025 09:26

kdy1 added this to the Planned milestone Oct 29, 2025

quininer force-pushed the r/switch-wasm-abi branch 2 times, most recently from eda5d89 to f756aac Compare October 30, 2025 02:46

kdy1 mentioned this pull request Oct 30, 2025

perf(plugin): hstr::Atom has very inefficient serialization/deserialization logic #11207

Open

quininer force-pushed the r/switch-wasm-abi branch 3 times, most recently from bf5f8ae to b82f905 Compare October 30, 2025 08:24

quininer marked this pull request as ready for review October 30, 2025 08:25

quininer requested a review from a team as a code owner October 30, 2025 08:25

Copilot AI review requested due to automatic review settings October 30, 2025 08:25

quininer requested review from a team as code owners October 30, 2025 08:25

Copilot AI reviewed Oct 30, 2025

View reviewed changes

kdy1 self-assigned this Oct 30, 2025

quininer force-pushed the r/switch-wasm-abi branch from 30ea2b1 to ae17408 Compare October 30, 2025 10:09

Copilot AI review requested due to automatic review settings October 30, 2025 10:09

Copilot AI reviewed Oct 30, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 3, 2025 01:55

Copilot AI reviewed Nov 3, 2025

View reviewed changes

quininer and others added 7 commits November 3, 2025 10:16

Use custom kind

9560c66

Add lossless ast tests

d8254ce

Use UnsafeCell for allocated_bytes_ptr

c922112

Add wasm regression test

6a94fd0

fix unknown warn

c909359

move wasm_regression

a48c53c

fix fmt

7b7829b

quininer force-pushed the r/switch-wasm-abi branch from 4abc611 to 7b7829b Compare November 3, 2025 02:18

kdy1 reviewed Nov 3, 2025

View reviewed changes

crates/swc_common/src/plugin/serialized.rs Outdated Show resolved Hide resolved

kdy1 reviewed Nov 3, 2025

View reviewed changes

quininer added 3 commits November 3, 2025 11:42

Add swc_ast_unknown to plugin cli

f8ad758

PluginSerializedBytes from owned

30fd5d0

assert filename is none

ca93058

Copilot AI review requested due to automatic review settings November 3, 2025 03:49

fix review

1a00ca3

Copilot AI reviewed Nov 3, 2025

View reviewed changes

crates/ast_node/src/encoding/decode.rs Show resolved Hide resolved

Apply suggestion from @Copilot

f735956

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings November 3, 2025 06:17

Copilot AI reviewed Nov 3, 2025

View reviewed changes

crates/swc_common/src/syntax_pos.rs Show resolved Hide resolved

crates/ast_node/src/encoding/decode.rs Show resolved Hide resolved

Copilot AI review requested due to automatic review settings November 3, 2025 06:22

Copilot AI reviewed Nov 3, 2025

View reviewed changes

crates/swc_common/src/syntax_pos.rs Outdated Show resolved Hide resolved

crates/swc_common/src/syntax_pos.rs Outdated Show resolved Hide resolved

crates/ast_node/src/encoding/decode.rs Show resolved Hide resolved

quininer force-pushed the r/switch-wasm-abi branch from 62b37b3 to f735956 Compare November 3, 2025 06:58

kdy1 approved these changes Nov 3, 2025

View reviewed changes

kdy1 merged commit e5feaf1 into swc-project:main Nov 3, 2025
318 of 369 checks passed

quininer deleted the r/switch-wasm-abi branch November 3, 2025 07:45

Uh oh!

refactor(plugin): Switch plugin abi to flexible serialization #11198

refactor(plugin): Switch plugin abi to flexible serialization #11198

Uh oh!

Conversation

quininer commented Oct 28, 2025

Uh oh!

changeset-bot bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

codspeed-hq bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #11198 will not alter performance

Summary

Uh oh!

socket-security bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

github-actions bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Sizes

Uh oh!

quininer commented Oct 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kdy1 Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

kdy1 Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kdy1 commented Nov 3, 2025

Uh oh!

quininer commented Nov 3, 2025

Uh oh!

kdy1 commented Nov 3, 2025

Uh oh!

changeset-bot bot commented Oct 28, 2025 •

edited

Loading

codspeed-hq bot commented Oct 28, 2025 •

edited

Loading

socket-security bot commented Oct 29, 2025 •

edited

Loading

github-actions bot commented Oct 30, 2025 •

edited

Loading